Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python client-based stresstest #1223

Merged
merged 6 commits into from
Oct 23, 2020
Merged

Add Python client-based stresstest #1223

merged 6 commits into from
Oct 23, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Oct 12, 2020

This PR adds a new stresstest module for perspective-python using the new PerspectiveTornadoClient, which is a far superior way to write Perspective stresstests and remote clients in Python. Instead of measuring per-message time, the new stresstest allows the user to write arbitary tasks and measure the progress of those tasks over multiple concurrent clients.

To use the new stresstest, run yarn bench -h to see the available options and configurations. Examples are located in python/perspective/bench/tornado, and can be run as follows:

yarn bench python/perspective/bench/tornado/distributed_mode.py -c10 ws://localhost:8080/websocket

Changelog

  • Added new Python client-based stresstest suite
  • Removed all code referring to old, custom-written stresstest suite
  • Split Python benchmarks into runtime and tornado
  • Added new-style benchmarks for distributed mode and server mode

@sc1f sc1f added enhancement Feature requests or improvements Python labels Oct 12, 2020
@sc1f sc1f requested a review from texodus October 12, 2020 19:47
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@texodus
Copy link
Member

texodus commented Oct 23, 2020

Thanks for the PR!

@texodus texodus merged commit f03ec97 into master Oct 23, 2020
@texodus texodus deleted the new-stresstest branch October 23, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants